Check if audits is loaded before executing database queries #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing, but I like the idea. |
|
@danielmorrison thanks, will fix test failures |
wkirby
force-pushed
the
apsis/loaded-audits
branch
from
48088fc
to
b7f99e8
Compare
wkirby
force-pushed
the
apsis/loaded-audits
branch
from
b7f99e8
to
1b72a97
Compare
|
@danielmorrison specs are now passing except for code coverage (see the test run on our fork here: https://github.com/apsislabs/audited/actions/runs/10538941999?pr=1). I believe this is because of the addition of the new I'm happy to either:
|
|
@danielmorrison just thought I'd poke in here and see if you had an answer for how you wanted me to handle the new untested lines? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be a no-op change that allows for performance improvements by preloading the
auditsassociation. By checking if theauditsassociation is already loaded, we can avoid N+1 queries by operating on the already loaded audits in ruby instead of going to the database again to check if a version exists, etc.This code should be functionally identical to the existing code, but allows for something like:
To avoid repeated database access.
Fixes #719